feat(remote_wal): introduce region meta and integrate it into creating table metadata #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niebayes
requested review from
WenyXu,
MichaelScofield,
fengjiachun,
v0y4g3r and
evenyag
WenyXu
reviewed
Nov 28, 2023
| /// A region's unique wal metadata. | ||
| // FIXME(niebayes): Shall String or RegionWalMetaKey be used as the key type? | ||
| #[derive(Default, Debug, Serialize, Deserialize, Clone, PartialEq)] | ||
| pub struct RegionWalMeta(HashMap<String, String>); |
There was a problem hiding this comment.
Suggested change
| pub struct RegionWalMeta(HashMap<String, String>); | |
| pub type RegionWalMeta = HashMap<String, String>; |
|
|
||
| use crate::region_meta::wal_meta::RegionWalMeta; | ||
|
|
||
| /// Stores a region's unique metadata. Any common metadata or options among regions shall not be stored in the struct. |
There was a problem hiding this comment.
Suggested change
| /// Stores a region's unique metadata. Any common metadata or options among regions shall not be stored in the struct. | |
| /// Stores a region's unique metadata. Any common metadata or options among regions should not be stored in the struct. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
RegionMetato store per-region unique metadata. Currently, it stores per-region unique wal metadata which is stored inRegionWalMeta.RegionMetainDatanodeTableValueand integrate persisting region metas into creating table metadata.This PR is part of the Kafka Remote Wal project. With this feature, the
TableMetadataAllocatoris able to allocate per-region unique metadata while handling create table requests. The allocated metadata will be persisted during creating table metadata by the procedure manager. On the other hand, a datanode is able to fetch regions' unique metadata during initializing region servers, so that regions can be opened properly.Checklist
Refer to a related PR or issue link (optional)
#2753
#2816