-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add upgrade candidate region step #2829
Merged
MichaelScofield
merged 3 commits into
GreptimeTeam:develop
from
WenyXu:feat/upgrade-candidate-region
Dec 4, 2023
Merged
feat: add upgrade candidate region step #2829
MichaelScofield
merged 3 commits into
GreptimeTeam:develop
from
WenyXu:feat/upgrade-candidate-region
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2829 +/- ##
===========================================
- Coverage 84.74% 84.42% -0.32%
===========================================
Files 740 740
Lines 115767 116244 +477
===========================================
+ Hits 98105 98141 +36
- Misses 17662 18103 +441 |
WenyXu
force-pushed
the
feat/upgrade-candidate-region
branch
2 times, most recently
from
November 28, 2023 08:02
75889ae
to
3ab250f
Compare
fengjiachun
reviewed
Nov 29, 2023
src/meta-srv/src/procedure/region_migration/upgrade_candidate_region.rs
Outdated
Show resolved
Hide resolved
WenyXu
force-pushed
the
feat/upgrade-candidate-region
branch
3 times, most recently
from
November 30, 2023 03:31
2fe6a2d
to
86c3fbf
Compare
fengjiachun
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
src/meta-srv/src/procedure/region_migration/upgrade_candidate_region.rs
Outdated
Show resolved
Hide resolved
src/meta-srv/src/procedure/region_migration/upgrade_candidate_region.rs
Outdated
Show resolved
Hide resolved
src/meta-srv/src/procedure/region_migration/upgrade_candidate_region.rs
Outdated
Show resolved
Hide resolved
src/meta-srv/src/procedure/region_migration/upgrade_candidate_region.rs
Outdated
Show resolved
Hide resolved
src/meta-srv/src/procedure/region_migration/upgrade_candidate_region.rs
Outdated
Show resolved
Hide resolved
@MichaelScofield PTAL |
WenyXu
force-pushed
the
feat/upgrade-candidate-region
branch
from
December 1, 2023 11:50
d11f127
to
a50c0b5
Compare
src/meta-srv/src/procedure/region_migration/upgrade_candidate_region.rs
Outdated
Show resolved
Hide resolved
@MichaelScofield PTAL |
MichaelScofield
approved these changes
Dec 4, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add upgrade candidate region step:
It upgrades a candidate region to a leader region with a retry; if all retry fails, it will rollback the metadata.
Behaviors:
Retry:
require_ready
is true, but the candidate region returnsready
is false.Abort:
Checklist
Refer to a related PR or issue link (optional)
#2700