Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upgrade candidate region step #2829

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 28, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add upgrade candidate region step:
It upgrades a candidate region to a leader region with a retry; if all retry fails, it will rollback the metadata.

Behaviors:
Retry:

  • If require_ready is true, but the candidate region returns ready is false.
  • MailboxTimeout.

Abort:

  • The candidate region doesn't exist.
  • PusherNotFound, The datanode is unreachable.
  • PushMessage, The receiver is dropped.
  • MailboxReceiver, The sender is dropped without sending (impossible).
  • UnexpectedInstructionReply (impossible).
  • Invalid JSON (impossible).

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2700

@WenyXu WenyXu mentioned this pull request Nov 28, 2023
39 tasks
@WenyXu WenyXu self-assigned this Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #2829 (42d9e67) into develop (781f242) will decrease coverage by 0.32%.
Report is 1 commits behind head on develop.
The diff coverage is 93.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2829      +/-   ##
===========================================
- Coverage    84.74%   84.42%   -0.32%     
===========================================
  Files          740      740              
  Lines       115767   116244     +477     
===========================================
+ Hits         98105    98141      +36     
- Misses       17662    18103     +441     

@WenyXu WenyXu force-pushed the feat/upgrade-candidate-region branch 2 times, most recently from 75889ae to 3ab250f Compare November 28, 2023 08:02
@WenyXu WenyXu force-pushed the feat/upgrade-candidate-region branch 3 times, most recently from 2fe6a2d to 86c3fbf Compare November 30, 2023 03:31
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@WenyXu
Copy link
Member Author

WenyXu commented Nov 30, 2023

@MichaelScofield PTAL

@WenyXu WenyXu force-pushed the feat/upgrade-candidate-region branch from d11f127 to a50c0b5 Compare December 1, 2023 11:50
@WenyXu
Copy link
Member Author

WenyXu commented Dec 4, 2023

@MichaelScofield PTAL

@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2023
@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 4, 2023
Merged via the queue into GreptimeTeam:develop with commit 7a14db6 Dec 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants