Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix name verifying #2825

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 27, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fix allowing the creation of a table/database with an invalid name bug.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #2825 (65cac8e) into develop (7547e7e) will decrease coverage by 0.32%.
The diff coverage is 72.72%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2825      +/-   ##
===========================================
- Coverage    84.75%   84.43%   -0.32%     
===========================================
  Files          734      734              
  Lines       115111   115131      +20     
===========================================
- Hits         97562    97212     -350     
- Misses       17549    17919     +370     

@WenyXu WenyXu force-pushed the fix/name-verifying branch from eef04dd to 65cac8e Compare November 27, 2023 11:54
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to verify column names?

@WenyXu
Copy link
Member Author

WenyXu commented Nov 28, 2023

Do we need to verify column names?

Column name seems to encode with base64. cc @waynexia

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fengjiachun fengjiachun added this pull request to the merge queue Nov 28, 2023
Merged via the queue into GreptimeTeam:develop with commit e42767d Nov 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants