Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix procedure loaders not found issue #2824

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 27, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Fix procedure loaders not found issue.
  2. Add unit test to ensure all loaders are registered.

The procedure LocalManager needs a Loader to convert the serialized data to an executable one. However, Before this PR, in the standalone mode, we didn't register these loaders🥲

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

fix #2823

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #2824 (09c3939) into develop (0badb37) will decrease coverage by 0.40%.
Report is 1 commits behind head on develop.
The diff coverage is 84.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2824      +/-   ##
===========================================
- Coverage    84.78%   84.38%   -0.40%     
===========================================
  Files          734      734              
  Lines       114940   115111     +171     
===========================================
- Hits         97450    97142     -308     
- Misses       17490    17969     +479     

Copy link
Contributor

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Nov 27, 2023
Merged via the queue into GreptimeTeam:develop with commit 7547e7e Nov 27, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loader not found for metasrv-procedure::CreateTable
3 participants