Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sqlness for decimal128 #2822

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Nov 27, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

some sqlness test cases for decimal128 type,
and include

  • common select.
  • create, insert, delete, drop, subquery, join, order by.
  • decimal cast with numeric, string, decimal itself.
  • math operators and some aggregation function.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Closes #2682

@QuenKar QuenKar marked this pull request as ready for review November 29, 2023 07:52
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #2822 (2b36c5d) into develop (bd9c2f2) will decrease coverage by 0.39%.
Report is 11 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2822      +/-   ##
===========================================
- Coverage    84.78%   84.39%   -0.39%     
===========================================
  Files          734      734              
  Lines       114927   115175     +248     
===========================================
- Hits         97440    97204     -236     
- Misses       17487    17971     +484     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank u!

@killme2008
Copy link
Contributor

@v0y4g3r @evenyag @waynexia Please take a look.

@killme2008 killme2008 added this pull request to the merge queue Dec 4, 2023
Merged via the queue into GreptimeTeam:develop with commit dac7a41 Dec 4, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Decimal128 type for datatype system
4 participants