Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update README.md Add JS Client link #2821

Merged
merged 2 commits into from
Nov 27, 2023
Merged

docs: Update README.md Add JS Client link #2821

merged 2 commits into from
Nov 27, 2023

Conversation

hygkui
Copy link
Contributor

@hygkui hygkui commented Nov 27, 2023 •
edited
Loading

Add JS Client link
see #2820

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

waynexia
waynexia approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hygkui

cc @alili

@waynexia waynexia changed the title Update README.md Add JS Client link docs: Update README.md Add JS Client link Nov 27, 2023
@waynexia waynexia requested a review from alili November 27, 2023 06:38
fengjiachun
fengjiachun approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Nov 27, 2023
@killme2008 killme2008 removed this pull request from the merge queue due to a manual request Nov 27, 2023
github-merge-queue bot pushed a commit that referenced this pull request Nov 27, 2023
@hygkui
docs: Update README.md Add JS Client link (#2821)
a157443 
Update README.md Add JS Client link

Add JS Client link
killme2008
killme2008 reviewed Nov 27, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@killme2008 killme2008 enabled auto-merge November 27, 2023 14:23
@killme2008 killme2008 added this pull request to the merge queue Nov 27, 2023
Merged via the queue into GreptimeTeam:develop with commit b1d8812 Nov 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 left review comments

@waynexia waynexia waynexia approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@alili alili Awaiting requested review from alili

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hygkui @killme2008 @fengjiachun @waynexia