-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Script for set up LD_LIBRARY_PATH with pyo3 release #2814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@discord9 What's the status of this PR? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2814 +/- ##
===========================================
+ Coverage 84.73% 84.90% +0.17%
===========================================
Files 749 749
Lines 117900 117995 +95
===========================================
+ Hits 99900 100185 +285
+ Misses 18000 17810 -190 |
killme2008
reviewed
Dec 4, 2023
zyy17
reviewed
Dec 6, 2023
nitpick: This file name |
daviderli614
reviewed
Dec 6, 2023
daviderli614
reviewed
Dec 6, 2023
discord9
force-pushed
the
script_wrapper
branch
from
December 6, 2023 08:29
cae84fe
to
8fb40c6
Compare
zyy17
reviewed
Dec 6, 2023
@discord9 After using your script, I have some suggestions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Added
greptime.sh
script which will try to find or set up proper version of python shared library. Will update later in document in Python script getting start section to ease setup of environment.Please explain IN DETAIL what the changes are in this PR and why they are needed:
a script that set up python shared library path and run exectuable, i.e.
./greptim.sh standalone start
Checklist
Refer to a related PR or issue link (optional)