Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Script for set up LD_LIBRARY_PATH with pyo3 release #2814

Closed
wants to merge 11 commits into from

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Nov 24, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Added greptime.sh script which will try to find or set up proper version of python shared library. Will update later in document in Python script getting start section to ease setup of environment.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
    a script that set up python shared library path and run exectuable, i.e. ./greptim.sh standalone start

Checklist

  • Windows support
  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@killme2008
Copy link
Contributor

@discord9 What's the status of this PR?

@discord9 discord9 marked this pull request as ready for review November 30, 2023 06:43
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #2814 (24f5e56) into develop (f9e7762) will increase coverage by 0.17%.
Report is 6 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2814      +/-   ##
===========================================
+ Coverage    84.73%   84.90%   +0.17%     
===========================================
  Files          749      749              
  Lines       117900   117995      +95     
===========================================
+ Hits         99900   100185     +285     
+ Misses       18000    17810     -190     

scripts/check_pyo3_link_script.sh Outdated Show resolved Hide resolved
scripts/greptime.sh Outdated Show resolved Hide resolved
scripts/greptime.sh Outdated Show resolved Hide resolved
scripts/check_pyo3_link_script.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
scripts/greptime.sh Outdated Show resolved Hide resolved
scripts/greptime.sh Outdated Show resolved Hide resolved
scripts/greptime.sh Outdated Show resolved Hide resolved
@daviderli614
Copy link
Member

nitpick: This file name greptime.sh is strange.

scripts/greptime.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
scripts/run-pyo3-greptime.sh Outdated Show resolved Hide resolved
scripts/run-pyo3-greptime.sh Outdated Show resolved Hide resolved
scripts/run-pyo3-greptime.sh Outdated Show resolved Hide resolved
@zyy17
Copy link
Collaborator

zyy17 commented Dec 8, 2023

@discord9 After using your script, I have some suggestions:

  1. Should we need a default value for GREPTIME_BIN_PATH? It seems the path is not always ./greptime. I think we should make -f as the required args;
  2. The args parsing has the bugs(The rest args cannot pass to the greptime):
./run-pyo3-greptime.sh -f ./target/debug/greptime --version                                                                                                                                                                     
Invalid option: --

@discord9 discord9 closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants