-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add update metadata step for rollbacking downgraded region #2812
feat: add update metadata step for rollbacking downgraded region #2812
Conversation
76d83a4
to
71d44ce
Compare
71d44ce
to
6896f2d
Compare
6896f2d
to
e716d67
Compare
Can we add a "rollback" method in |
BTW, Currently, we avoid this problem by carefully designing the procedure steps. It ensures all non-retriable errors eventually do not affect the system. |
Yes, the runner already has a greptimedb/src/common/procedure/src/local/runner.rs Lines 455 to 469 in fe2fc72
However, fully supporting We should consider when and how to mark a procedure as rollbacked. We should run
Currently, this might be the simplest way. We can support rollback in the future, which still requires a lot of effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2812 +/- ##
===========================================
- Coverage 84.79% 84.42% -0.38%
===========================================
Files 737 740 +3
Lines 115840 115980 +140
===========================================
- Hits 98224 97911 -313
- Misses 17616 18069 +453 |
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add update metadata step for rolling back downgraded region.
It will roll back the downgraded leader region if the candidate region is unreachable.
Behaviors:
Abort(non-retry):
Retry:
Checklist
Refer to a related PR or issue link (optional)
#2700