Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add update metadata step for upgrading candidate region #2811

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 24, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add update metadata step for upgrading candidate region.

It sets the candidate peer as the leader_peer and removes the candidate region from follower_peers if any.

Behaviors:

Abort(non-retry):

  • TableRoute or RegionRoute is not found.
    Typically, it's impossible, there is no other DDL procedure executed concurrently for the current table.

Retry:

  • Failed to update TableRouteValue
  • Failed to retrieve the metadata of the table.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2700

@WenyXu WenyXu self-assigned this Nov 24, 2023
@WenyXu WenyXu force-pushed the feat/update-metadata-upgrading branch from 76d83a4 to 2bc4fec Compare November 24, 2023 07:38
@WenyXu WenyXu closed this Nov 24, 2023
@WenyXu WenyXu changed the title feat: add update metadata step for rollbacking downgraded region feat: add update metadata step for upgrading candidate region Nov 24, 2023
@WenyXu WenyXu reopened this Nov 24, 2023
@WenyXu WenyXu marked this pull request as ready for review November 24, 2023 07:40
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #2811 (30f5c4a) into develop (cce5edc) will decrease coverage by 0.31%.
The diff coverage is 92.81%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2811      +/-   ##
===========================================
- Coverage    84.78%   84.47%   -0.31%     
===========================================
  Files          735      737       +2     
  Lines       115557   115840     +283     
===========================================
- Hits         97974    97860     -114     
- Misses       17583    17980     +397     

@WenyXu WenyXu mentioned this pull request Nov 24, 2023
39 tasks
@WenyXu WenyXu force-pushed the feat/update-metadata-upgrading branch from 2bc4fec to 0b31d9f Compare November 27, 2023 06:51
@WenyXu
Copy link
Member Author

WenyXu commented Nov 29, 2023

@MichaelScofield @fengjiachun PTAL

@WenyXu WenyXu force-pushed the feat/update-metadata-upgrading branch from 0b31d9f to 30f5c4a Compare November 29, 2023 09:44
@MichaelScofield MichaelScofield added this pull request to the merge queue Nov 29, 2023
Merged via the queue into GreptimeTeam:develop with commit ae81535 Nov 29, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants