Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sample ratio in trace #2809

Merged
merged 2 commits into from
Nov 27, 2023
Merged

feat: support sample ratio in trace #2809

merged 2 commits into from
Nov 27, 2023

Conversation

Taylor-lagrange
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

support sample ratio in trace, add config tracing_sample_ratio

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • support sample ratio in trace, add config tracing_sample_ratio
  • fix error config of manifest_compress_type in standalone.example.toml

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@waynexia
Copy link
Member

The "Uncompressed" regression is from #2765

@waynexia waynexia enabled auto-merge November 24, 2023 02:54
auto-merge was automatically disabled November 24, 2023 03:24

Head branch was pushed to by a user without write access

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #2809 (471a136) into develop (4c76d4d) will decrease coverage by 0.14%.
Report is 3 commits behind head on develop.
The diff coverage is 50.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2809      +/-   ##
===========================================
- Coverage    84.49%   84.36%   -0.14%     
===========================================
  Files          729      730       +1     
  Lines       113510   113741     +231     
===========================================
+ Hits         95913    95960      +47     
- Misses       17597    17781     +184     

@waynexia waynexia added this pull request to the merge queue Nov 27, 2023
Merged via the queue into GreptimeTeam:develop with commit 0badb37 Nov 27, 2023
18 checks passed
@Taylor-lagrange Taylor-lagrange deleted the feat-tracing-sample branch November 27, 2023 08:17
@WenyXu WenyXu added the docs-required This change requires docs update. label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants