feat(inverted_index): add index reader #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2803 +/- ##
===========================================
- Coverage 84.74% 84.38% -0.37%
===========================================
Files 732 734 +2
Lines 114657 114927 +270
===========================================
- Hits 97168 96983 -185
- Misses 17489 17944 +455 |
killme2008
approved these changes
Nov 24, 2023
Signed-off-by: Zhenchi <[email protected]>
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
* feat(inverted_index): add reader Signed-off-by: Zhenchi <[email protected]> * fix: toml format Signed-off-by: Zhenchi <[email protected]> * chore: add prefix relative_ to the offset parameter Signed-off-by: Zhenchi <[email protected]> * docs: add doc comment Signed-off-by: Zhenchi <[email protected]> --------- Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
evenyag
reviewed
Nov 24, 2023
Signed-off-by: Zhenchi <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Introduce the trait
InvertedIndexReaderand its implementation.Depends on GreptimeTeam/greptime-proto#124.
Checklist
Refer to a related PR or issue link (optional)
#2705
GreptimeTeam/greptime-proto#124