Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(puffin): remove tests #2789

Merged

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Nov 21, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

For the next PR to re-add the tests.rs file to make it a text file.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@killme2008 killme2008 enabled auto-merge November 21, 2023 09:54
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #2789 (7b1b867) into develop (99dbb74) will decrease coverage by 0.69%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2789      +/-   ##
===========================================
- Coverage    84.42%   83.73%   -0.69%     
===========================================
  Files          728      727       -1     
  Lines       113349   113113     -236     
===========================================
- Hits         95692    94715     -977     
- Misses       17657    18398     +741     

@killme2008 killme2008 added this pull request to the merge queue Nov 21, 2023
Merged via the queue into GreptimeTeam:develop with commit bdb677d Nov 21, 2023
12 checks passed
@zhongzc zhongzc deleted the zhongzc/puffin-remove-tests-file branch November 21, 2023 10:13
@zhongzc zhongzc mentioned this pull request Nov 21, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants