-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supports decimal type in RPC #2788
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2788 +/- ##
===========================================
- Coverage 84.47% 84.34% -0.14%
===========================================
Files 728 731 +3
Lines 113352 114517 +1165
===========================================
+ Hits 95756 96587 +831
- Misses 17596 17930 +334 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review the rest parts after the proto is updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a feature and not only refactors the ColumnDataTypeWrapper. @QuenKar Could you edit the title? And I think it actually supports decimal type in RPC.
Co-authored-by: Yingwen <[email protected]>
Co-authored-by: Yingwen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
main change:
refactor ColumnDataTypeWrapper
ColumnDataTypeWrapper
can convert withConcreteDataType
.(refactorFrom/TryFrom
trait).ColumnDataType::xxx_datatype()
to create, as ConcreteDataType style.datatype()
can get(ColumnDataType, Option<ColumnDataTypeExtension>)
, which is needed byColumnSchema
,ColumnDef
andColumn
.try_new
to construct aColumnDataTypeWrapper
.Checklist
Refer to a related PR or issue link (optional)
#2682
GreptimeTeam/greptime-proto#122