feat: add set_readonly_gracefully for engine
#2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
force-pushed
the
feat/region-set-readonly
branch
from
1f60090 to
18f2217
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2787 +/- ##
===========================================
- Coverage 84.48% 84.39% -0.10%
===========================================
Files 729 731 +2
Lines 113510 113930 +420
===========================================
+ Hits 95899 96148 +249
- Misses 17611 17782 +171 |
waynexia
reviewed
Nov 22, 2023
evenyag
reviewed
Nov 22, 2023
evenyag
reviewed
Nov 23, 2023
WenyXu
force-pushed
the
feat/region-set-readonly
branch
from
18f2217 to
058f354
Compare
WenyXu
force-pushed
the
feat/region-set-readonly
branch
from
058f354 to
2cdaad3
Compare
evenyag
reviewed
Nov 24, 2023
fengjiachun
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The
set_readonly_gracefullymethod sets a read-only flag for a region and ensures no more write operations will succeed after it returns.Checklist
Refer to a related PR or issue link (optional)