Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bring back inactive_region_ids #2783

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 21, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

bring back inactive_region_ids

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #2783 (3242457) into develop (5f87b1f) will decrease coverage by 0.35%.
Report is 1 commits behind head on develop.
The diff coverage is 88.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2783      +/-   ##
===========================================
- Coverage    84.41%   84.06%   -0.35%     
===========================================
  Files          722      722              
  Lines       113216   113223       +7     
===========================================
- Hits         95567    95183     -384     
- Misses       17649    18040     +391     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Nov 21, 2023
Merged via the queue into GreptimeTeam:develop with commit 43a7457 Nov 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants