Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade etcd-client to 0.12.2 #2781

Merged
merged 4 commits into from
Nov 21, 2023
Merged

build: upgrade etcd-client to 0.12.2 #2781

merged 4 commits into from
Nov 21, 2023

Conversation

tisonkun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Following I'll create a few follow-ups to improve the code and prepare to add chroot for etcd connection.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Cargo.toml Outdated Show resolved Hide resolved
@tisonkun
Copy link
Collaborator Author

cc @MichaelScofield

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #2781 (026ecee) into develop (b9146c8) will decrease coverage by 0.26%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2781      +/-   ##
===========================================
- Coverage    84.36%   84.10%   -0.26%     
===========================================
  Files          722      722              
  Lines       113216   113043     -173     
===========================================
- Hits         95513    95076     -437     
- Misses       17703    17967     +264     

tisonkun and others added 3 commits November 20, 2023 22:38
@tisonkun tisonkun requested a review from sunng87 November 21, 2023 00:25
@tisonkun
Copy link
Collaborator Author

cc @fengjiachun

@waynexia waynexia enabled auto-merge November 21, 2023 03:46
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Nov 21, 2023
Merged via the queue into GreptimeTeam:develop with commit efc5abf Nov 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants