Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove usages of the old storage crate #2777

Merged
merged 10 commits into from
Nov 20, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Nov 20, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR removes the storage crate from other crates' dependency lists. The real storage engine is mito2.

It moves the BufferedWriter to the common-datasource crate so COPY TO can use it to write parquet files. Now COPY TO calls stream_to_parquet() directly.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review November 20, 2023 10:03
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #2777 (1e975f9) into develop (d9eeeee) will decrease coverage by 1.49%.
Report is 2 commits behind head on develop.
The diff coverage is 57.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2777      +/-   ##
===========================================
- Coverage    85.53%   84.05%   -1.49%     
===========================================
  Files          783      722      -61     
  Lines       127088   113259   -13829     
===========================================
- Hits        108711    95197   -13514     
+ Misses       18377    18062     -315     

@v0y4g3r v0y4g3r merged commit b9146c8 into GreptimeTeam:develop Nov 20, 2023
33 of 34 checks passed
@niebayes niebayes mentioned this pull request Dec 11, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants