Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mysql writer does not print error message in some cases #2763

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Nov 16, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR fixes the issue that our MySQL handler may not print the error message to users.

It outputs OK but the query actually fails if the error is an internal error.

Query OK (0.02 sec)

Now users can see the internal error message.

ERROR 1815 (HY000): Internal error: 1003

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review November 17, 2023 02:58
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag requested a review from fengjiachun November 17, 2023 02:59
@evenyag evenyag enabled auto-merge November 17, 2023 03:01
@evenyag evenyag added this pull request to the merge queue Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #2763 (e93d014) into develop (d2cf72e) will decrease coverage by 0.41%.
Report is 2 commits behind head on develop.
The diff coverage is 16.66%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2763      +/-   ##
===========================================
- Coverage    85.38%   84.97%   -0.41%     
===========================================
  Files          774      774              
  Lines       125811   125936     +125     
===========================================
- Hits        107419   107018     -401     
- Misses       18392    18918     +526     

Merged via the queue into GreptimeTeam:develop with commit 06da33b Nov 17, 2023
22 checks passed
@evenyag evenyag deleted the fix/mysql-error branch November 17, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants