feat: write logical region to metric engine #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2759 +/- ##
===========================================
- Coverage 85.42% 85.05% -0.37%
===========================================
Files 769 774 +5
Lines 125115 126269 +1154
===========================================
+ Hits 106881 107401 +520
- Misses 18234 18868 +634 |
fengjiachun
reviewed
Nov 16, 2023
Signed-off-by: Ruihang Xia <[email protected]>
evenyag
reviewed
Nov 17, 2023
Signed-off-by: Ruihang Xia <[email protected]>
evenyag
approved these changes
Nov 17, 2023
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Handle region put request in metric engine. Only put request to logical region is allowed for now.
This PR also changes the internal column
__metricto__table_id. Instead of using metric name (or table name), table id is more suitable at this region engine layer.Checklist
Refer to a related PR or issue link (optional)