Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable distributed tracing in greptimedb #2755

Merged
merged 7 commits into from
Nov 17, 2023
Merged

feat: Enable distributed tracing in greptimedb #2755

merged 7 commits into from
Nov 17, 2023

Conversation

Taylor-lagrange
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Enable distributed tracing in greptimedb

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  1. Updated grpc proto for communication between frontend,meta,datanodes, adding tracing_context to rpc request header, enable distributed tracing in frontend,meta,datanodes.
  2. Use otlp as exporter protocol, which can support distributed tracing backend like jaeger, tempo.....
  3. add config enable_otlp_tracing, otlp_endpoint to logging config, enable user to export tracing to distributed tracing backend.
  4. instrument span on sql dispose logical, enable sql execute time consuming observations

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

GreptimeTeam/greptime-proto#120

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #2755 (96a019a) into develop (06327fb) will decrease coverage by 0.37%.
The diff coverage is 75.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2755      +/-   ##
===========================================
- Coverage    85.38%   85.02%   -0.37%     
===========================================
  Files          774      774              
  Lines       125959   125375     -584     
===========================================
- Hits        107552   106601     -951     
- Misses       18407    18774     +367     

Copy link
Contributor

@shuiyisong shuiyisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FGTM 🚀

src/common/telemetry/src/lib.rs Outdated Show resolved Hide resolved
src/common/telemetry/src/tracing_context.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl_manager.rs Outdated Show resolved Hide resolved
@waynexia waynexia enabled auto-merge November 17, 2023 08:42
@waynexia waynexia added this pull request to the merge queue Nov 17, 2023
Merged via the queue into GreptimeTeam:develop with commit 500e299 Nov 17, 2023
18 checks passed
@Taylor-lagrange Taylor-lagrange deleted the feat-tracing branch November 17, 2023 09:37
@sunng87 sunng87 added the docs-required This change requires docs update. label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants