feat(puffin): add file reader #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhenchi <[email protected]>
7 tasks
Signed-off-by: Zhenchi <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2751 +/- ##
===========================================
- Coverage 85.42% 85.14% -0.29%
===========================================
Files 769 781 +12
Lines 125115 126253 +1138
===========================================
+ Hits 106881 107497 +616
- Misses 18234 18756 +522 |
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
|
@waynexia @fengjiachun @evenyag PTAL 🕸️ |
evenyag
reviewed
Nov 17, 2023
Co-authored-by: Yingwen <[email protected]>
Co-authored-by: Yingwen <[email protected]>
Co-authored-by: Yingwen <[email protected]>
Co-authored-by: Yingwen <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
|
All comments are addressed, PTAL again @evenyag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add parser for Puffin in sync and async manner.
Mainly introduce
PuffinSyncReaderandPuffinAsyncReadertraits and implementations.Please note that
src/puffin/src/tests.rsis not a bin file, check it by clicking View File.Checklist
Refer to a related PR or issue link (optional)
#2705