Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move sqlness env show test to common dir #2748

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

poltao
Copy link
Contributor

@poltao poltao commented Nov 14, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

close #2500

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia enabled auto-merge November 14, 2023 14:03
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2748 (6dabaa2) into develop (3dffc7b) will decrease coverage by 0.38%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2748      +/-   ##
===========================================
- Coverage    85.31%   84.93%   -0.38%     
===========================================
  Files          765      765              
  Lines       124537   124537              
===========================================
- Hits        106247   105778     -469     
- Misses       18290    18759     +469     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thank u.

@waynexia waynexia added this pull request to the merge queue Nov 14, 2023
Merged via the queue into GreptimeTeam:develop with commit a9e5b90 Nov 14, 2023
12 checks passed
@poltao poltao deleted the dev/tests branch November 14, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tests/cases/distributed/show and tests/cases/standalone/show to common dir
3 participants