Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ignore file not found error temporarily while compacting files #2745

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Nov 14, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR temporarily ignores files not found during compaction. We use this to workaround the issue caused by #2746

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2746

@evenyag evenyag marked this pull request as ready for review November 14, 2023 14:03
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2745 (a415bb5) into develop (e2a770f) will decrease coverage by 0.38%.
Report is 2 commits behind head on develop.
The diff coverage is 68.75%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2745      +/-   ##
===========================================
- Coverage    85.31%   84.93%   -0.38%     
===========================================
  Files          765      765              
  Lines       124537   124551      +14     
===========================================
- Hits        106249   105789     -460     
- Misses       18288    18762     +474     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into GreptimeTeam:develop with commit f92b55c Nov 15, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants