Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(puffin): add partial reader #2741

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Nov 14, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

PartialReader is used to read a contiguous segment of bytes from a resource. For the blob format, by providing the offset and size of the blob, one can utilize PartialReader to read the content of the Blob.
This PR introduces PartialReader and implements std::io::Read, std::io::Seek, futures::io::AsyncRead, and futures::io::AsyncSeek for it.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2705

@zhongzc zhongzc requested review from waynexia, evenyag and fengjiachun and removed request for waynexia November 14, 2023 06:35
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2741 (cc25250) into develop (dc46e96) will decrease coverage by 0.39%.
Report is 1 commits behind head on develop.
The diff coverage is 97.72%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2741      +/-   ##
===========================================
- Coverage    85.31%   84.92%   -0.39%     
===========================================
  Files          765      769       +4     
  Lines       124537   124889     +352     
===========================================
- Hits        106247   106066     -181     
- Misses       18290    18823     +533     

@zhongzc zhongzc self-assigned this Nov 14, 2023
Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Zhenchi <[email protected]>
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Nov 15, 2023
Merged via the queue into GreptimeTeam:develop with commit 3329da5 Nov 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants