Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run dist planner after simplify expression rule #2723

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Nov 9, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Run SimplifyExpressions before the dist planner to distribute more plans.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

refer to #2720

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L?TM

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DLJB

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2723 (ce46e5d) into develop (93f21b1) will decrease coverage by 0.39%.
Report is 3 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2723      +/-   ##
===========================================
- Coverage    85.17%   84.79%   -0.39%     
===========================================
  Files          765      765              
  Lines       123911   123981      +70     
===========================================
- Hits        105545   105132     -413     
- Misses       18366    18849     +483     

@waynexia waynexia added this pull request to the merge queue Nov 9, 2023
Merged via the queue into GreptimeTeam:develop with commit f02dc0e Nov 9, 2023
14 checks passed
@waynexia waynexia deleted the dist-after-simplify branch November 9, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants