-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Puffin format #2721
Conversation
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2721 +/- ##
===========================================
- Coverage 85.17% 84.88% -0.29%
===========================================
Files 765 775 +10
Lines 123940 125020 +1080
===========================================
+ Hits 105565 106125 +560
- Misses 18375 18895 +520 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is binary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only github knows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.dev works fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the mod.rs
occupy 8.25KB?
By the way, can we remove mod.rs
? Most crates in the project don't use mod.rs
:
https://doc.rust-lang.org/edition-guide/rust-2018/path-changes.html#no-more-modrs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the mod.rs
occupy 8.25KB?
By the way, can we remove mod.rs
? Most crates in the project don't use mod.rs
:
https://doc.rust-lang.org/edition-guide/rust-2018/path-changes.html#no-more-modrs
It's average. 40B/line * 200lines = 8KB
Sure.
We can move out when the implementation becomes more mature and stable. Multiple repos will affect development efficiency.
good suggestion |
Maybe we should create a |
Do you mean creating a new repo? |
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Part of #2705
implement {sync|async} {reader|writer} for Puffin.
Checklist
Refer to a related PR or issue link (optional)