-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial implement for promql subquery #2707
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
==========================================
- Coverage 85.41% 85.16% -0.25%
==========================================
Files 932 763 -169
Lines 155075 122920 -32155
==========================================
- Hits 132451 104690 -27761
+ Misses 22624 18230 -4394 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! But i think we should add some test cases for this feature.
Test cases in prometheus are a little complicated. I'm going to make a new sqlness interceptor for them. |
@waynexia Don't forget this PR. 👍 |
Waiting for CeresDB/sqlness#51 |
Signed-off-by: Ruihang Xia <[email protected]>
@waynexia as you know the sqlness blocker is unblocked. Reminder for this issue :D |
Close as stale. The changeset of this patch is small. I suppose when we'd like to pick it up, we can open a new PR. |
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Support query like
avg by (job) (avg_over_time((up <= 50)[5s:5s]))
This PR only handles range and step in subquery. Other parameters are ignored.
Checklist
Refer to a related PR or issue link (optional)