fix: refactor and fix to_unixtime #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2695 +/- ##
===========================================
- Coverage 84.91% 84.81% -0.10%
===========================================
Files 743 763 +20
Lines 120832 122599 +1767
===========================================
+ Hits 102604 103984 +1380
- Misses 18228 18615 +387 |
killme2008
force-pushed
the
feature/fix-to-unixtime
branch
from
6e48402 to
6a8500c
Compare
v0y4g3r
reviewed
Nov 6, 2023
NiwakaDev
reviewed
Nov 6, 2023
waynexia
reviewed
Nov 6, 2023
tests/cases/standalone/common/types/string/scan_big_varchar.sql
Outdated
Show resolved
Hide resolved
|
@waynexia PTAL |
waynexia
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Main changes:
to_unixtimeprocess theTimestampMillisecondVectorandTimestampNanosecondVectornot correctly, return the wrong value. It should return the unix timestamp in seconds.to_unixtimefunction to avoid some unnecessary conversions.datetype.Checklist
Refer to a related PR or issue link (optional)