Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add '--server-addr' in sqlness runner #2692

Merged

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Nov 3, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add --server-addr in sqlness runner, we can run the tests like:

cargo sqlness --server-addr 127.0.0.1:14001 --test-filter standalone

cargo sqlness --server-addr 127.0.0.1:24001 --test-filter distributed

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

closes #2635

@zyy17 zyy17 requested review from fengys1996, MichaelScofield and waynexia and removed request for fengys1996 and MichaelScofield November 3, 2023 09:11
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2692 (6ed4f83) into develop (6fd04e3) will decrease coverage by 0.43%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

❗ Current head 6ed4f83 differs from pull request most recent head b1766a5. Consider uploading reports for the commit b1766a5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2692      +/-   ##
===========================================
- Coverage    85.15%   84.73%   -0.43%     
===========================================
  Files          762      762              
  Lines       122342   121864     -478     
===========================================
- Hits        104181   103261     -920     
- Misses       18161    18603     +442     

@zyy17
Copy link
Collaborator Author

zyy17 commented Nov 5, 2023

It seems the --mode is duplicated with --test-filter. I'll remove it later.

@zyy17 zyy17 changed the title feat: add '--server-addr' and '--mode' in sqlness runner feat: add '--server-addr' in sqlness runner Nov 5, 2023
tests/runner/src/env.rs Outdated Show resolved Hide resolved
@zyy17 zyy17 force-pushed the feat/sqlness-runner-with-server-addr branch 2 times, most recently from 2aba411 to 3d6849c Compare November 6, 2023 09:33
@zyy17 zyy17 force-pushed the feat/sqlness-runner-with-server-addr branch from 3d6849c to b1766a5 Compare November 6, 2023 09:40
@zyy17 zyy17 requested a review from killme2008 November 6, 2023 09:40
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @waynexia PTAL

@waynexia waynexia enabled auto-merge November 6, 2023 10:55
@waynexia waynexia added this pull request to the merge queue Nov 6, 2023
Merged via the queue into GreptimeTeam:develop with commit cf94d32 Nov 6, 2023
13 checks passed
@zyy17 zyy17 deleted the feat/sqlness-runner-with-server-addr branch November 6, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance sqlness harness to accept a connection string
3 participants