Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify the KvBackend #2684

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 2, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Unify the KvBackend
  2. Rename kv_store to kv_backend

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2684 (7643b7a) into develop (ce867fb) will decrease coverage by 0.37%.
The diff coverage is 75.13%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2684      +/-   ##
===========================================
- Coverage    85.09%   84.73%   -0.37%     
===========================================
  Files          758      755       -3     
  Lines       121219   121202      -17     
===========================================
- Hits        103148   102695     -453     
- Misses       18071    18507     +436     

src/common/meta/src/kv_backend.rs Outdated Show resolved Hide resolved
src/meta-srv/src/service/store/cached_kv.rs Outdated Show resolved Hide resolved
@WenyXu
Copy link
Member Author

WenyXu commented Nov 2, 2023

@fengjiachun PTAL

@WenyXu WenyXu force-pushed the refactor/etcd-store branch from 0ff25af to 7643b7a Compare November 3, 2023 02:32
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@fengjiachun fengjiachun added this pull request to the merge queue Nov 3, 2023
Merged via the queue into GreptimeTeam:develop with commit fb8d0c6 Nov 3, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants