fix: add back mut ref #2669
Merged
fix: add back mut ref #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunng87
approved these changes
Oct 31, 2023
yuanbohan
approved these changes
Oct 31, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2669 +/- ##
===========================================
- Coverage 85.00% 84.65% -0.35%
===========================================
Files 743 739 -4
Lines 120636 120417 -219
===========================================
- Hits 102541 101943 -598
- Misses 18095 18474 +379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The mut ref is used for modifying contents of the options in function from other distros. Adding
#[allow(clippy::unnecessary_mut_passed)]to pass clippy check.Checklist
Refer to a related PR or issue link (optional)