Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: events or links to string #2667

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

yuanbohan
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix events_to_string and links_to_string via Serializable Struct

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@yuanbohan yuanbohan force-pushed the otlp-trace-attributes-to-json branch 2 times, most recently from c61740b to 1e0f4b0 Compare October 30, 2023 09:41
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #2667 (1e0f4b0) into develop (d0ff8ab) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2667      +/-   ##
===========================================
- Coverage    85.03%   84.96%   -0.07%     
===========================================
  Files          743      743              
  Lines       120576   120611      +35     
===========================================
- Hits        102532   102483      -49     
- Misses       18044    18128      +84     

Copy link
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuanbohan yuanbohan added this pull request to the merge queue Oct 31, 2023
Merged via the queue into develop with commit 84bcca9 Oct 31, 2023
@yuanbohan yuanbohan deleted the otlp-trace-attributes-to-json branch October 31, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants