Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: region disk usage statistic #2665

Merged
merged 9 commits into from
Oct 31, 2023
Merged

feat: region disk usage statistic #2665

merged 9 commits into from
Oct 31, 2023

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Oct 27, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • region stat includes memtable(estimated), wal(estimated), sst(accurate), manifest(accurate) .
  • engine can invoke get_region_stat to get specific region stat.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2551

@QuenKar QuenKar changed the title feat: region size statistic feat: region usage statistic Oct 27, 2023
@QuenKar QuenKar changed the title feat: region usage statistic feat: region disk usage statistic Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #2665 (9065e3f) into develop (d0ff8ab) will decrease coverage by 0.43%.
Report is 3 commits behind head on develop.
The diff coverage is 61.70%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2665      +/-   ##
===========================================
- Coverage    85.03%   84.61%   -0.43%     
===========================================
  Files          743      743              
  Lines       120576   120701     +125     
===========================================
- Hits        102532   102127     -405     
- Misses       18044    18574     +530

@QuenKar QuenKar marked this pull request as draft October 28, 2023 04:02
@QuenKar QuenKar marked this pull request as ready for review October 30, 2023 02:11
@QuenKar
Copy link
Contributor Author

QuenKar commented Oct 30, 2023 •
edited
Loading

test_to_timezone_aware_string failed, looks like there is something wrong about timezone.

evenyag
evenyag reviewed Oct 30, 2023
View reviewed changes
src/mito2/src/region.rs Outdated Show resolved Hide resolved
src/mito2/src/region.rs Outdated Show resolved Hide resolved
@QuenKar QuenKar marked this pull request as draft October 30, 2023 09:22
@QuenKar QuenKar force-pushed the feat/region-size-statistic branch from a055a3e to e62a170 Compare October 30, 2023 09:54
@QuenKar QuenKar marked this pull request as ready for review October 30, 2023 09:59
evenyag
evenyag approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/mito2/src/engine.rs Outdated Show resolved Hide resolved
@QuenKar @evenyag
chore: cr comment.
19defc3 
Co-authored-by: Yingwen <[email protected]>
@waynexia waynexia added this pull request to the merge queue Oct 31, 2023
Merged via the queue into GreptimeTeam:develop with commit 36c0742 Oct 31, 2023
12 checks passed
@evenyag evenyag mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@evenyag evenyag evenyag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuenKar @evenyag @waynexia