feat(mito): avoid buffering all batches for the same primary key #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2658 +/- ##
===========================================
- Coverage 84.99% 84.68% -0.31%
===========================================
Files 743 743
Lines 120701 120977 +276
===========================================
- Hits 102592 102452 -140
- Misses 18109 18525 +416 |
evenyag
force-pushed
the
feat/merge-batch-size
branch
from
f0de78b to
151ee1e
Compare
evenyag
force-pushed
the
feat/merge-batch-size
branch
from
151ee1e to
c2b0082
Compare
waynexia
reviewed
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements the merge reader in a more streaming way. The merge reader checks whether the buffered rows of the batch are more than
batch_sizeand outputs the batch if it exceedsbatch_size. This may slow down the reader but the query engine may benefit from a larger batch.It adds more tests to check the correctness of this behavior.
#2660 describes the merge algorithm.
Checklist
Refer to a related PR or issue link (optional)
#2660