Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add serde default to MitoConfig #2650

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Oct 24, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR derives serde(default) for MitoConfig

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review October 24, 2023 10:39
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2650 (47779b3) into develop (01fdbf3) will decrease coverage by 0.32%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2650      +/-   ##
===========================================
- Coverage    84.90%   84.58%   -0.32%     
===========================================
  Files          743      743              
  Lines       120672   120672              
===========================================
- Hits        102455   102075     -380     
- Misses       18217    18597     +380     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Oct 24, 2023
Merged via the queue into GreptimeTeam:develop with commit 16a3257 Oct 24, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants