-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: predicate shall use real schema to create physical exprs #2642
Merged
v0y4g3r
merged 8 commits into
GreptimeTeam:develop
from
v0y4g3r:fix/predicate-prune-schema-mismatch
Oct 24, 2023
Merged
fix: predicate shall use real schema to create physical exprs #2642
v0y4g3r
merged 8 commits into
GreptimeTeam:develop
from
v0y4g3r:fix/predicate-prune-schema-mismatch
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0y4g3r
changed the title
fix: prune predicate show use real schema to create physical exprs
fix: predicate shall use real schema to create physical exprs
Oct 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2642 +/- ##
===========================================
- Coverage 84.95% 84.54% -0.42%
===========================================
Files 743 743
Lines 120609 120672 +63
===========================================
- Hits 102469 102027 -442
- Misses 18140 18645 +505 |
killme2008
reviewed
Oct 23, 2023
killme2008
added
C-bug
Category Bugs
A-storage
Involves code in storage engines
priority:high
labels
Oct 23, 2023
killme2008
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
waynexia
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
evenyag
reviewed
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR fixes the incorrect behavior when pruning memtable time series using the schema from
RegionMetadata
.The bug originates from how
Predicate
used for pruning generates physical expr, because the indices for primary keys in primary key record batch may differ from the indices defined inRegionMetadata
. Instead, in this fix we postpone the generation of physical exprs until evaluation and explicitly requires callers to provide a schema for physical expr generation so that those physical expr will have the save schema as record batch evaluated.Checklist
Refer to a related PR or issue link (optional)