Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mito): Ports InMemoryRowGroup from parquet crate #2633

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Oct 20, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR copies InMemoryRowGroup from parquet crate and changes its visibility to pub.

This is the first step to implementing a row group level reader in our mito engine. There is an example that shows how to use try_new_with_row_groups() to read by row groups. Our row group level reader will use a similar approach.

A RowGroups implementation is necessary so we port it from the parquet crate. Now this PR doesn't change any logic.

I will introduce logical changes in the next PR so we don't need to care about the implementation of the InMemoryRowGroup.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review October 20, 2023 12:41
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #2633 (82f3ebb) into develop (212ea2c) will decrease coverage by 0.50%.
Report is 2 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2633      +/-   ##
===========================================
- Coverage    85.15%   84.66%   -0.50%     
===========================================
  Files          740      741       +1     
  Lines       119840   119990     +150     
===========================================
- Hits        102055   101589     -466     
- Misses       17785    18401     +616     

@evenyag
Copy link
Contributor Author

evenyag commented Oct 20, 2023

Well, there are some clippy warnings...... I will fix them in the next PR too as I'm not going to introduce additional changes.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move on!

@evenyag evenyag added this pull request to the merge queue Oct 23, 2023
Merged via the queue into GreptimeTeam:develop with commit 82dbc3e Oct 23, 2023
12 checks passed
@evenyag evenyag deleted the feat/mito2-row-group branch October 23, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants