Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RepeatedTask adds execute-first-wait-later behavior. #2625

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

paomian
Copy link
Contributor

@paomian paomian commented Oct 19, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

RepeatedTask adds execute-first-wait-later behavior.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@paomian paomian requested review from etolbakov, killme2008, WenyXu and evenyag and removed request for etolbakov October 19, 2023 08:05
@paomian paomian force-pushed the chore/repeated-task branch from 45a3dc3 to 65756de Compare October 19, 2023 08:18
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2625 (274a072) into develop (ba15c14) will decrease coverage by 0.38%.
Report is 7 commits behind head on develop.
The diff coverage is 85.71%.

❗ Current head 274a072 differs from pull request most recent head 32538d8. Consider uploading reports for the commit 32538d8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2625      +/-   ##
===========================================
- Coverage    85.17%   84.79%   -0.38%     
===========================================
  Files          738      740       +2     
  Lines       119070   119865     +795     
===========================================
+ Hits        101413   101641     +228     
- Misses       17657    18224     +567     

src/common/runtime/src/repeated_task.rs Outdated Show resolved Hide resolved
src/common/runtime/src/repeated_task.rs Outdated Show resolved Hide resolved
@paomian paomian force-pushed the chore/repeated-task branch from 48b3364 to 5215edc Compare October 19, 2023 14:34
src/common/runtime/src/repeated_task.rs Outdated Show resolved Hide resolved
src/common/runtime/src/repeated_task.rs Outdated Show resolved Hide resolved
@paomian paomian force-pushed the chore/repeated-task branch from 8b09341 to 274a072 Compare October 20, 2023 08:56
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/common/runtime/src/repeated_task.rs Show resolved Hide resolved
@paomian paomian requested a review from killme2008 October 20, 2023 09:23
@paomian paomian force-pushed the chore/repeated-task branch from e6288c6 to 32538d8 Compare October 20, 2023 09:27
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Oct 20, 2023
Merged via the queue into GreptimeTeam:develop with commit 89ebe47 Oct 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants