Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: the 'publish-github-release' and 'release-cn-artifacts' have to wait for all the artifacts are built #2622

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Oct 18, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

ci: the 'publish-github-release' and 'release-cn-artifacts' have to wait for all the artifacts are built

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2622 (fe4b121) into develop (d57b144) will decrease coverage by 0.36%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2622      +/-   ##
===========================================
- Coverage    85.16%   84.80%   -0.36%     
===========================================
  Files          738      738              
  Lines       118955   118955              
===========================================
- Hits        101304   100878     -426     
- Misses       17651    18077     +426     

@sunng87 sunng87 added this pull request to the merge queue Oct 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 19, 2023
@waynexia waynexia merged commit 6439b92 into GreptimeTeam:develop Oct 19, 2023
11 checks passed
@zyy17 zyy17 deleted the ci/dependency-error branch October 20, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants