Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct the range behavior in MemoryKvBackend & RaftEngineBackend #2615

Merged
merged 7 commits into from
Oct 20, 2023
Merged

fix: correct the range behavior in MemoryKvBackend & RaftEngineBackend #2615

merged 7 commits into from
Oct 20, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Oct 18, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Correct the range behavior in MemoryKvBackend & RaftEngineBackend

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

close #2616

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #2615 (80fae1e) into develop (3217b56) will decrease coverage by 0.30%.
Report is 5 commits behind head on develop.
The diff coverage is 95.69%.

❗ Current head 80fae1e differs from pull request most recent head f012bde. Consider uploading reports for the commit f012bde to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2615      +/-   ##
===========================================
- Coverage    85.14%   84.85%   -0.30%     
===========================================
  Files          738      739       +1     
  Lines       118319   119101     +782     
===========================================
+ Hits        100747   101059     +312     
- Misses       17572    18042     +470

@WenyXu WenyXu mentioned this pull request Oct 18, 2023
Closed
2 tasks
@WenyXu WenyXu marked this pull request as draft October 18, 2023 06:33
@WenyXu WenyXu changed the title fix: correct the range behavior in Memory KvBackend fix: correct the range behavior in MemoryKvBackend & RaftEngineBackend Oct 18, 2023
@WenyXu WenyXu marked this pull request as ready for review October 18, 2023 07:57
@WenyXu WenyXu requested review from fengjiachun and v0y4g3r October 18, 2023 07:57
@WenyXu
Copy link
Member Author

WenyXu commented Oct 18, 2023

@MichaelScofield @fengjiachun PTAL

fengjiachun
fengjiachun reviewed Oct 18, 2023
View reviewed changes
src/common/meta/src/kv_backend/memory.rs Outdated Show resolved Hide resolved
src/common/meta/src/kv_backend/memory.rs Show resolved Hide resolved
src/log-store/src/raft_engine/backend.rs Outdated Show resolved Hide resolved
fengjiachun
fengjiachun approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu force-pushed the fix/mem-kv-range branch 2 times, most recently from 2fa46ed to 06daf6f Compare October 18, 2023 11:57
@WenyXu WenyXu force-pushed the fix/mem-kv-range branch 2 times, most recently from 2fa46ed to 06daf6f Compare October 18, 2023 12:04
@MichaelScofield MichaelScofield added this pull request to the merge queue Oct 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 19, 2023
@MichaelScofield MichaelScofield added this pull request to the merge queue Oct 20, 2023
Merged via the queue into GreptimeTeam:develop with commit e1dcf83 Oct 20, 2023
10 checks passed
@poltao poltao mentioned this pull request Apr 14, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct the behaviors in KvBackend implements
3 participants
@WenyXu @MichaelScofield @fengjiachun