Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make ReadableSize more readable. #2614

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Oct 18, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

make ReadableSize debug format for better readable.
for example:
run cargo run -- standalone start, and we can see some log info.
previous format:

wal: WalConfig {
        dir: None,
        file_size: ReadableSize(
            268435456,
        ),
        purge_threshold: ReadableSize(
            4294967296,
        ),
        purge_interval: 600s,
        read_batch_size: 128,
        sync_write: false,
    },

current format:

wal: WalConfig {
        dir: None,
        file_size: 256.0MiB,
        purge_threshold: 4.0GiB,
        purge_interval: 600s,
        read_batch_size: 128,
        sync_write: false,
    },

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2614 (2f550ef) into develop (3217b56) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

❗ Current head 2f550ef differs from pull request most recent head 36b6b5b. Consider uploading reports for the commit 36b6b5b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2614      +/-   ##
===========================================
- Coverage    85.14%   84.77%   -0.37%     
===========================================
  Files          738      738              
  Lines       118319   118322       +3     
===========================================
- Hits        100747   100312     -435     
- Misses       17572    18010     +438     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Oct 18, 2023
@evenyag evenyag removed this pull request from the merge queue due to a manual request Oct 18, 2023
@evenyag evenyag enabled auto-merge October 18, 2023 06:21
@evenyag evenyag added this pull request to the merge queue Oct 18, 2023
Merged via the queue into GreptimeTeam:develop with commit 5b8e506 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants