Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get internal value size of ValueRef #2613

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Oct 18, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

get the byte size of the internal elements of ValueRef.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2613 (edee847) into develop (3217b56) will decrease coverage by 0.35%.
Report is 4 commits behind head on develop.
The diff coverage is 96.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2613      +/-   ##
===========================================
- Coverage    85.14%   84.80%   -0.35%     
===========================================
  Files          738      738              
  Lines       118319   119070     +751     
===========================================
+ Hits        100747   100977     +230     
- Misses       17572    18093     +521     

src/datatypes/src/value.rs Outdated Show resolved Hide resolved
src/datatypes/src/value.rs Outdated Show resolved Hide resolved
src/datatypes/src/value.rs Outdated Show resolved Hide resolved
@evenyag evenyag requested a review from v0y4g3r October 19, 2023 02:33
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Oct 19, 2023
@evenyag evenyag removed this pull request from the merge queue due to a manual request Oct 19, 2023
@evenyag evenyag merged commit ba15c14 into GreptimeTeam:develop Oct 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants