Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refine release-cn-artifacts action #2600

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Oct 13, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Refine release-cn-artifacts action:

  1. Add upload-artifacts-to-s3.sh and copy-image.sh to make the release operations decouple from GitHub Actions yaml files(Provide the option to run it locally);

  2. Modify the related workflows to adapt the above scripts;

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@zyy17 zyy17 requested review from sunng87 and daviderli614 October 13, 2023 06:58
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2600 (86501d4) into develop (cf6ef0a) will decrease coverage by 0.42%.
Report is 4 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2600      +/-   ##
===========================================
- Coverage    85.39%   84.98%   -0.42%     
===========================================
  Files          737      737              
  Lines       117986   118012      +26     
===========================================
- Hits        100754   100289     -465     
- Misses       17232    17723     +491     

@zyy17 zyy17 requested review from evenyag and waynexia October 13, 2023 09:01
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels good

@zyy17 zyy17 merged commit 6e87ac0 into GreptimeTeam:develop Oct 13, 2023
11 checks passed
@zyy17 zyy17 deleted the ci/add-release-cn-artifacts-script branch October 13, 2023 09:04
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* ci: add copy-image.sh and upload-artifacts-to-s3.sh

* ci: remove unused options in dev build

* ci: use 'upload-artifacts-to-s3.sh' and 'copy-image.sh' in release-cn-artifacts action

* refactor: refine copy-image.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants