Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make nyc-taxi bench work again #2599

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Oct 13, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

The request created by the nyc-taxi bench is invalid under 0.4. This PR fixes the issue and appends a timestamp to the table name to avoid table name conflicts.

Here is my test result on mbp 14 2021

[00:00:04] ############################################################ 2463931/2463931 file "/Users/evenyag/codes/greptime/greptimedb/benchmarks/data/yellow_tripdata_2022-01.parquet" done in 4048msRunning query: SELECT passenger_count, MIN(fare_amount), MAX(fare_amount), SUM(fare_amount) FROM nyc_taxi_1697182595 GROUP BY passenger_count
query fare_amt_by_passenger, iteration 0: 269ms
query fare_amt_by_passenger, iteration 1: 188ms
query fare_amt_by_passenger, iteration 2: 153ms
Running query: SELECT COUNT(*) FROM nyc_taxi_1697182595;
query count_all, iteration 0: 126ms
query count_all, iteration 1: 121ms
query count_all, iteration 2: 121ms

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review October 13, 2023 06:55
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2599 (21104df) into develop (f859932) will decrease coverage by 0.38%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2599      +/-   ##
===========================================
- Coverage    85.34%   84.97%   -0.38%     
===========================================
  Files          737      737              
  Lines       118012   118026      +14     
===========================================
- Hits        100722   100295     -427     
- Misses       17290    17731     +441     

@waynexia waynexia enabled auto-merge October 13, 2023 08:02
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚕

benchmarks/src/bin/nyc-taxi.rs Outdated Show resolved Hide resolved
@killme2008
Copy link
Contributor

Can we add some sample data and make this running in CI? I wonder if we don't have it in CI, it will be broken again.

@evenyag
Copy link
Contributor Author

evenyag commented Oct 13, 2023

Can we add some sample data and make this running in CI? I wonder if we don't have it in CI, it will be broken again.

It needs to run a greptimedb server in the background which is inconvenient to do in CI and hard to debug. I plan to remove this benchmark after our TSBS benchmark is ready.

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Oct 13, 2023
Merged via the queue into GreptimeTeam:develop with commit 8a0054a Oct 13, 2023
11 checks passed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
* fix: invalid requests created by nyc-taxi

* feat: add timestamp to table name

* style: fix clippy

* chore: re-export deps for client

* fix: wait result

* chore: no need to define a prefix constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants