-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make nyc-taxi bench work again #2599
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2599 +/- ##
===========================================
- Coverage 85.34% 84.97% -0.38%
===========================================
Files 737 737
Lines 118012 118026 +14
===========================================
- Hits 100722 100295 -427
- Misses 17290 17731 +441 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚕
Can we add some sample data and make this running in CI? I wonder if we don't have it in CI, it will be broken again. |
It needs to run a greptimedb server in the background which is inconvenient to do in CI and hard to debug. I plan to remove this benchmark after our TSBS benchmark is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: invalid requests created by nyc-taxi * feat: add timestamp to table name * style: fix clippy * chore: re-export deps for client * fix: wait result * chore: no need to define a prefix constant
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The request created by the nyc-taxi bench is invalid under 0.4. This PR fixes the issue and appends a timestamp to the table name to avoid table name conflicts.
Here is my test result on mbp 14 2021
Checklist
Refer to a related PR or issue link (optional)