Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: downgrade builder version: ubuntu 22.04 -> ubuntu 20.04 for compatible with older version glibc(>=2.31) #2592

Merged
merged 1 commit into from
Oct 12, 2023
Merged

ci: downgrade builder version: ubuntu 22.04 -> ubuntu 20.04 for compatible with older version glibc(>=2.31) #2592

merged 1 commit into from
Oct 12, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Oct 12, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

ci: downgrade builder version: ubuntu 22.04 -> ubuntu 20.04 for compatible with older version glibc(>=2.31)

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

waynexia
waynexia approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if grpc dep in ubuntu 20.04 works. Let's try it out 🥲

@killme2008 killme2008 added this pull request to the merge queue Oct 12, 2023
@zyy17 zyy17 removed this pull request from the merge queue due to a manual request Oct 12, 2023
@zyy17 zyy17 merged commit 0a23b40 into GreptimeTeam:develop Oct 12, 2023
9 checks passed
@zyy17 zyy17 deleted the ci/downgrade-builder-version branch October 12, 2023 08:46
MichaelScofield added a commit to MichaelScofield/greptimedb that referenced this pull request Oct 16, 2023
@MichaelScofield
Revert "ci: downgrade builder version: ubuntu 22.04 -> ubuntu 20.04 f…
18666a5 
…or compatible with older version glibc(>=2.31) (GreptimeTeam#2592)"

This reverts commit 0a23b40.
@MichaelScofield MichaelScofield mentioned this pull request Oct 16, 2023
Merged
2 tasks
MichaelScofield added a commit that referenced this pull request Oct 16, 2023
@MichaelScofield
Revert "ci: downgrade builder version: ubuntu 22.04 -> ubuntu 20.04 f… (
fadd289 
#2607)

Revert "ci: downgrade builder version: ubuntu 22.04 -> ubuntu 20.04 for compatible with older version glibc(>=2.31) (#2592)"

This reverts commit 0a23b40.
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@zyy17 @paomian
ci: downgrade builder version: ubuntu 22.04 -> ubuntu 20.04 for compa…
0f7c35a 
…tible with older version glibc(>=2.31) (GreptimeTeam#2592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@sunng87 sunng87 sunng87 approved these changes

@killme2008 killme2008 Awaiting requested review from killme2008

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zyy17 @sunng87 @waynexia