Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auth in standalone mode #2591

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

shuiyisong
Copy link
Contributor

@shuiyisong shuiyisong commented Oct 12, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr mainly fixed user_provider option not working in standalone mode.

TODO(separate pr)

  • add more integration tests
  • support weekly SDK CI with regression test

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2578

@shuiyisong shuiyisong marked this pull request as ready for review October 13, 2023 08:13
@shuiyisong shuiyisong requested a review from fengys1996 October 13, 2023 08:13
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2591 (f1dbad2) into develop (65a659d) will decrease coverage by 0.39%.
Report is 5 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2591      +/-   ##
===========================================
- Coverage    85.36%   84.98%   -0.39%     
===========================================
  Files          737      737              
  Lines       118023   118016       -7     
===========================================
- Hits        100747   100291     -456     
- Misses       17276    17725     +449     

Copy link
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuiyisong shuiyisong added this pull request to the merge queue Oct 13, 2023
Merged via the queue into GreptimeTeam:develop with commit d89cfd0 Oct 13, 2023
25 checks passed
@shuiyisong shuiyisong deleted the fix/standalone_auth branch October 13, 2023 08:48
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
chore: user_provider in standalone mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants