chore(cli): deregister cli attach command #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
waynexia
requested review from
killme2008,
sunng87,
MichaelScofield and
evenyag
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2589 +/- ##
===========================================
- Coverage 85.36% 84.98% -0.38%
===========================================
Files 737 737
Lines 118020 117983 -37
===========================================
- Hits 100743 100265 -478
- Misses 17277 17718 +441 |
sunng87
approved these changes
Oct 12, 2023
|
@evenyag is modifying related part |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
After region server refactoring, datanode is not captiable for processing non-logical plan query. Thus I deregister
attachcommand from cli. We can add this functionality back in the future in others way, like require the frontend to only do partial query execution (to only include result from datanode, for example).Checklist
Refer to a related PR or issue link (optional)