Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change config name from kv_store to metadata_store #2585

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

change the config name kv_store to metadata_store for standalone

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

follow up of #2549

@github-actions github-actions bot added the breaking-change This pull request contains breaking changes. label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #2585 (83a33a6) into develop (9e33ddc) will decrease coverage by 0.37%.
The diff coverage is 80.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2585      +/-   ##
===========================================
- Coverage    85.36%   85.00%   -0.37%     
===========================================
  Files          737      737              
  Lines       118020   118020              
===========================================
- Hits        100753   100319     -434     
- Misses       17267    17701     +434     

@waynexia waynexia enabled auto-merge October 12, 2023 06:34
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Oct 12, 2023
Merged via the queue into GreptimeTeam:develop with commit 62bcb45 Oct 12, 2023
17 checks passed
@waynexia waynexia deleted the kv-config branch October 12, 2023 07:05
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
…am#2585)

featchange config name from kv_store to metadata_store

Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This pull request contains breaking changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants