feat: stop the procedure manager if a new leader is elected #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
requested review from
MichaelScofield,
fengjiachun,
evenyag and
NiwakaDev
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2576 +/- ##
===========================================
- Coverage 85.23% 84.77% -0.47%
===========================================
Files 738 738
Lines 118249 118587 +338
===========================================
- Hits 100794 100531 -263
- Misses 17455 18056 +601 |
fengjiachun
reviewed
Oct 12, 2023
WenyXu
force-pushed
the
feat/meta-procedure-stop
branch
from
3b59782 to
e5ee291
Compare
|
@fengjiachun @evenyag PTAL |
evenyag
reviewed
Oct 16, 2023
WenyXu
force-pushed
the
feat/meta-procedure-stop
branch
from
009c445 to
791f37a
Compare
WenyXu
force-pushed
the
feat/meta-procedure-stop
branch
from
791f37a to
6fc4078
Compare
|
@fengjiachun @evenyag PTAL |
2 tasks
evenyag
reviewed
Oct 17, 2023
evenyag
approved these changes
Oct 17, 2023
fengjiachun
reviewed
Oct 17, 2023
WenyXu
force-pushed
the
feat/meta-procedure-stop
branch
from
c9637a2 to
b6f3434
Compare
|
@fengjiachun PTAL |
fengjiachun
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
runningflag toManagerContext.Runneris stopped.Procedure Managerif a new leader is elected.Procedure Managerif the meta server becomes a leader.Checklist
Refer to a related PR or issue link (optional)
close #1721