Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: release Windows artifacts #2574

Merged
merged 2 commits into from
Oct 12, 2023
Merged

ci: release Windows artifacts #2574

merged 2 commits into from
Oct 12, 2023

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

As title.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@zyy17 zyy17 requested a review from daviderli614 October 11, 2023 08:10
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #2574 (192bec7) into develop (d7aeb36) will decrease coverage by 0.38%.
Report is 5 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2574      +/-   ##
===========================================
- Coverage    85.36%   84.99%   -0.38%     
===========================================
  Files          737      737              
  Lines       118020   118020              
===========================================
- Hits        100747   100306     -441     
- Misses       17273    17714     +441

zyy17
zyy17 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's greptime time on Windows 👍

@MichaelScofield MichaelScofield added this pull request to the merge queue Oct 12, 2023
@zyy17 zyy17 removed this pull request from the merge queue due to a manual request Oct 12, 2023
@zyy17 zyy17 merged commit fc3bc53 into GreptimeTeam:develop Oct 12, 2023
11 checks passed
@MichaelScofield MichaelScofield deleted the ci/release-windows branch October 13, 2023 02:10
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@MichaelScofield @paomian
ci: release Windows artifacts (GreptimeTeam#2574)
bda5da3 
* ci: release Windows artifacts

* ci: release Windows artifacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviderli614 daviderli614 daviderli614 approved these changes

@zyy17 zyy17 zyy17 approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelScofield @zyy17 @daviderli614